Skip to content

feat: Add Valkey cache for scaling #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Add Valkey cache for scaling #700

wants to merge 6 commits into from

Conversation

@hardillb
Copy link
Contributor

@hardillb hardillb commented Oct 13, 2025 •
edited
Loading

fixes #699

Description

Adds a Valkey instance if more than 2 Forge app instances are configured.

Related Issue(s)

#699
FlowFuse/flowfuse#3642

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from ppawlowski October 13, 2025 13:01
@hardillb hardillb self-assigned this Oct 13, 2025
@hardillb hardillb changed the title Add Valkey cache for scaling Feat: Add Valkey cache for scaling Oct 13, 2025
@hardillb hardillb changed the title Feat: Add Valkey cache for scaling feat: Add Valkey cache for scaling Oct 13, 2025
@hardillb
Copy link
Contributor Author

Need to decide if we are happy with no auth to start with here?

@hardillb hardillb mentioned this pull request Oct 13, 2025
Open
8 tasks
ppawlowski
ppawlowski reviewed Oct 14, 2025
View reviewed changes
ppawlowski
ppawlowski reviewed Oct 14, 2025
View reviewed changes
@ppawlowski
Copy link
Contributor

Need to decide if we are happy with no auth to start with here?

If we are not going to store fragile data in the cache, I'm ok with no auth + network policy that will allow connections to the cache from the Forge deployment only.

@hardillb hardillb requested a review from ppawlowski October 14, 2025 16:40
ppawlowski
ppawlowski reviewed Oct 15, 2025
View reviewed changes
@hardillb @ppawlowski
Update helm/flowfuse/README.md
d6a9576 
Co-authored-by: PPawlowski <ppawlowski@users.noreply.github.com>
ppawlowski
ppawlowski reviewed Oct 15, 2025
View reviewed changes
@ppawlowski ppawlowski self-requested a review October 15, 2025 19:21
@hardillb hardillb marked this pull request as ready for review October 20, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppawlowski ppawlowski ppawlowski approved these changes

Assignees

@hardillb hardillb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Valkey and Cache configuration

2 participants

@hardillb @ppawlowski